Add labels to namespaces created during end to end tests #2340
Conversation
Besides that it is a good practice to label resources created this allows in this case easy deletion of the namespaces if: - there was an issue while running the tests - the variable TEST_KEEP_NAMESPACES was set - the tests were abruptly stopped by the developer Currently you have to run something like: $ kubectl get namespaces --no-headers=true -o custom-columns=:metadata.name | grep arendelle | xargs kubectl delete namespace This would become: $ kubectl delete ns -l "tekton.dev/test-e2e=true"
googlebot
added
the
cla: yes
tekton-robot
added
size/S
|
Hi @fgiloux. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
tekton-robot
added
ok-to-test
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/test pull-tekton-pipeline-integration-tests |
1 similar comment
|
/test pull-tekton-pipeline-integration-tests |
|
Neat! /test pull-tekton-pipeline-integration-tests |
Besides that it is a good practice to label resources created this allows in this case easy deletion of the namespaces if:
Currently you have to run something like:
$ kubectl get namespaces --no-headers=true -o custom-columns=:metadata.name | grep arendelle | xargs kubectl delete namespace
This would become:
$ kubectl delete ns -l "tekton.dev/test-e2e=true"
Changes
Changes are minimal:
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.